Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] User cannot remove last text node #51

Merged

Conversation

GeekTree0101
Copy link
Owner

Why need this change?:

  • In one media & last text area case, If user remove last text area than no more typing new text.

Change made & impact:

  • deleteUnnecessaryEditableTextIfNeeds:, blocking remove last text node

Test Scope:

  • private method

Vertified snapshots (optional)

@GeekTree0101 GeekTree0101 added the bug Something isn't working label Feb 11, 2019
@GeekTree0101 GeekTree0101 self-assigned this Feb 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   67.01%   67.01%           
=======================================
  Files          25       25           
  Lines        1737     1737           
=======================================
  Hits         1164     1164           
  Misses        573      573

@GeekTree0101 GeekTree0101 merged commit 33bfd75 into master Feb 11, 2019
@GeekTree0101 GeekTree0101 deleted the feature/VEditorKit-User-cannot-remove-last-textNode branch February 11, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants